[backport 2.14] - Automation: Fix fleet clusters handle error missing sub row element#17386
Conversation
richard-cox
left a comment
richard-cox
left a comment
There was a problem hiding this comment.
one minor comment, but the other is a major one (avoid loose ^ reference in package.json)
| fleetClusterDetailsPage.clusterTabs().clickTabWithSelector('[data-testid="btn-applications"]'); | ||
|
|
||
| // check cluster labels | ||
| fleetClusterDetailsPage.clusterLabels().contains('foo: bar').scrollIntoView().should('be.visible'); |
There was a problem hiding this comment.
should still be able to do ...subrows.contains('foo: bar')... either directly here or via the PO. these aboids the very loose clusterLabels self.find
There was a problem hiding this comment.
the change of
clusterLabels(): Cypress.Chainable {
return this.self().find('.tag-data');
to
hasClusterLabel(key: string, value: string) {
return this.self()
.find('.tag-data')
.contains(`${ key }: ${ value }`);
}
still suffers from the same problem (this.self().find). there's more information around this here
the original code looked at the subrows
fleetClusterListPage.list().resourceTable().sortableTable()
.subRows()
.should('contain.text', 'foo=bar');
can the solution also be to look at the table --> subrows with something like
fleetClusterListPage.list().resourceTable().sortableTable()
.subRows()
.contains('contain.text', 'foo=bar');
or
fleetClusterListPage.list().resourceTable().sortableTable()
.subRows()
.find('.tag-data')
.contains('contain.text', 'foo=bar');
izaac
left a comment
izaac
left a comment
There was a problem hiding this comment.
Squash and re-request reviews.
a-arias
force-pushed
the
backport/2.14/2268-fleet-cluster-subwow-pt2-F
branch
from
f4f7710 to
6133c97
Compare
| "@parcel/watcher-win32-ia32" "2.5.0" | ||
| "@parcel/watcher-win32-x64" "2.5.0" | ||
|
|
||
| "@percy/cli-app@1.31.8": |
There was a problem hiding this comment.
I think this isn't necessary here. You should take a look at the qa-infra playbook
3 participants
Summary
Fixes rancher/qa-tasks#2268
Backport of #17035
Fixed a validation error where a sub-row element was not found.
Additionally, the code layout was corrected and a test option was added to ensure proper visibility.
Screenshot/Video
Checklist
Admin,Standard UserandUser Base